[libvirt] [PATCH 0/2] snapshot: add getName API

Eric Blake eblake at redhat.com
Thu Sep 8 13:41:18 UTC 2011


On 09/08/2011 02:22 PM, Daniel Veillard wrote:
> On Thu, Sep 08, 2011 at 01:21:09PM +0100, Eric Blake wrote:
>> I know I've missed the 0.9.5 RC1 freeze, but think that this
>> new API is worth adding, if only because I noticed that
>> 'virsh snapshot-create dom --no-metadata' currently creates
>> a snapshot with a generated name but then fails in attempting
>> to express that name to the user.
>>
>> Eric Blake (2):
>>    snapshot: new APIs for inspecting snapshot object
>>    snapshot: use new API for less work
>>
>>   include/libvirt/libvirt.h.in |    4 ++
>>   src/libvirt.c                |   73 ++++++++++++++++++++++++++++++++++++++++++
>>   src/libvirt_public.syms      |    5 ++-
>>   tools/virsh.c                |   41 +++++------------------
>>   4 files changed, 90 insertions(+), 33 deletions(-)
>
>    Okay, the accessors make sense and the amount of changes
> are minimal. The improvement of virsh.c make their need very clear
>
>   ACK to the 2 patches

Pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list