[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5] virsh: Add more human-friendly output of domblkstat command



Dňa 12.9.2011 16:27, Peter Krempa wrote / napísal(a):
diff --git a/tools/virsh.c b/tools/virsh.c
index 3b060bf..766c9be 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1090,76 +1118,105 @@ cmdDomblkstat (vshControl *ctl, const vshCmd *cmd)
* then.
*/
if (rc< 0) {
- if (last_error->code != VIR_ERR_NO_SUPPORT) {
- virshReportError(ctl);
- } else {
- virFreeError(last_error);
- last_error = NULL;

Even if this patch gets NACKed, this part should be pushed as a separate patch (maybe with some tuning), as it breaks the backward compatibility with daeamons compiled against older versions of libvirt.

After calling this command against an older libvirt "error: unknown procedure: 243" appears and the command fails. This is because the remote driver supports the procedure but the RPC server doesn't. The error to be checked for should also contain VIR_ERR_RPC, which is reported on missing procedure on remote end.

Peter Krempa


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]