[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix typos for snapshot-create-as in virsh help cmd and doc



On 09/14/2011 12:06 PM, Nan Zhang wrote:
* tools/virsh.c: Using VSH_OT_STRING instead of VSH_OT_ARGV for diskspec

Nack.  This MUST be VSH_OT_ARGV, in order to allow multiple diskspec.

* tools/virsh.pod: Fix missing -- tag for snapshot-create-as in docs

Nack. This is intentional - if all earlier options with arguments are provided, then you can write 'snapshot-create-as dom name description vda' instead of the identical 'snapashot-create-as dom name description --diskspec vda'

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]