[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Transfer inactive XML among cookie

On 09/15/2011 08:38 AM, Michal Privoznik wrote:
So the max size of string is 65K. BUT, because we don't sent 2 XML in
one RPC I don't think we are gonna hit that limit soon. My patch sent
domain XML among with cookie which is small, not 2 XMLs at the same
time. Right now, at the finish phase - which is the place where I send
domain xml - the size of cookie is 222B + sizeof(domain name).

Therefore I think there is no need to increase the bound for string.

Thanks; that answered my concerns. By sending the original xml between begin/prepare, but the persistent xml in the cookie between perform/finish, you've split the work, so that neither send is inordinately large. No problem then, and I was over-reacting :)

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]