[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Require augeas for sanlock

On 09/15/2011 08:57 AM, Michal Privoznik wrote:
Even though we BuildRequire augeas in some cases, we need to require
it even after if we build with sanlock. virt-sanlock-cleanup use it.
  libvirt.spec.in |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 648b50f..4d69c77 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -354,6 +354,8 @@ BuildRequires: libpciaccess-devel>= 0.10.9
  BuildRequires: yajl-devel
  %if %{with_sanlock}
+#for virt-sanlock-cleanup
+Requires: augeas

The added line is right, but not in the right place. We've split the file so that the section on Requires is different than the section on BuildRequires. Can you float this line into the right place (it might mean duplicating the %if %{with_sanlock} conditional)?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]