[libvirt] [PATCH] Prevent crash from dlclose() of libvirt.so

Eric Blake eblake at redhat.com
Fri Sep 16 22:00:27 UTC 2011


On 09/01/2011 11:12 AM, Eric Blake wrote:
> On 09/01/2011 10:57 AM, Daniel P. Berrange wrote:
>> +++ b/src/Makefile.am
>> @@ -1228,7 +1228,7 @@ libvirt_qemu.def: $(srcdir)/libvirt_qemu.syms
>> libvirt_la_SOURCES =
>> libvirt_la_LDFLAGS = $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_SYMBOL_FILE) \
>> -version-info $(LIBVIRT_VERSION_INFO) \
>> - $(AM_LDFLAGS) \
>> + $(AM_LDFLAGS) $(LIBVIRT_NODELETE) \
>
> I would have listed this before $(AM_LDFLAGS), closer to the
> $(LIBVIRT_VERSION_INFO) linker flags.
>

...

>  > +
>  > + /* If we got to hear the thread succesfully exited without
>  > + * causing a SEGV !
>
> s/hear/here/; s/succesfully/successfully/
>
> ACK with nits fixed.

I've gone ahead and fixed the nits and pushed this.  It seems worth 
having in 0.9.5.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list