[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v2 5/5] vmx: avoid memory leak



* src/vmx/vmx.c: fix memory leak, 'def' has a initial value 'NULL', so 
  'goto cleanup' is perfected instead of adding a virConfFree before
  'return NULL'. 

Signed-off-by: Alex Jia <ajia redhat com>
---
 src/vmx/vmx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index dff3599..be91c13 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -1253,7 +1253,7 @@ virVMXParseConfig(virVMXContext *ctx, virCapsPtr caps, const char *vmx)
     /* Allocate domain def */
     if (VIR_ALLOC(def) < 0) {
         virReportOOMError();
-        return NULL;
+        goto cleanup;
     }
 
     def->virtType = VIR_DOMAIN_VIRT_VMWARE;
-- 
1.7.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]