[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: qxl devices don't support multifunction yet



Hi hi

On Fri, Sep 16, 2011 at 1:38 PM, Marc-André Lureau <mlureau redhat com> wrote:
>> >
>> > How do we allow other devices to share the slot? It seems to me that
>> > qemuDomainPCIAddressSetNextAddr() only allocate whole slot, while
>> > making sure there is no conflicts on the same slot.
>>
>> So, if the user wants to use multi function pci device, he should
>> specify the
>> pci address.
>
> So adding a check such as:
>
> if (!multiFunc && info->addr.pci.function != 0)
>   return error("The %s device doesn't support multifunction address")
>

Wen, does that sound reasonable to you?

Daniel, did you had time to verify that PCI allocation is per-slot?

(It would be nice to get this "workaround" for the next release)

thanks!

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]