[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] qemu: avoid memory leak



On 09/18/2011 10:36 AM, ajia redhat com wrote:
* src/qemu/qemu_command.c: fix memory leak.

Signed-off-by: Alex Jia<ajia redhat com>
---
  src/qemu/qemu_command.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index e8b1157..45d55fc 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6540,7 +6540,6 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps,
                      host = disk->src;
                      port = strchr(host, ':');
                      if (!port) {
-                        def = NULL;

Took me a few minutes of research to find when this stray line was introduced - we've had a leak on error since commit 036ad50 (0.8.7).

ACK and pushed.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]