[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] remote: avoid memory leak



On 09/18/2011 10:36 AM, ajia redhat com wrote:
* src/remote/remote_driver.c: fix memory leak.

Signed-off-by: Alex Jia<ajia redhat com>
---
  src/remote/remote_driver.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 9d34b7e..9f30432 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -3294,6 +3294,8 @@ no_memory:
          VIR_FREE(subject->identities);
          VIR_FREE(subject);
      }
+    if (dom)
+        virDomainFree(dom);

ACK that this is a leak, in remoteDomainBuildEventGraphics and introduced by commit 987e31e (v0.8.0). However, if we get here, we are guaranteed dom is non-NULL, so I removed the redundant if() before pushing.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]