[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: doc: Fix supported driver types for attach-disk command



On 09/19/2011 06:57 AM, Peter Krempa wrote:
Virsh man page lists driver types to be used with attach-device
command, but does not specify that those are usable only with the XEN
Hypervisor.

This patch adds statement, that those options specified are applicable
only on the Xen hypervisor and adds option usable with qemu emulator.

This patch also changes type of error returned by QEMU driver if the
user specifies incompatible driver type from VIR_ERR_INTERNAL_ERROR to
VIR_ERR_NO_SUPPORT.

Wrong error. NO_SUPPORT is for when a function is unimplemented; here we want CONFIG_UNSUPPORTED.

+++ b/tools/virsh.pod
@@ -1166,7 +1166,8 @@ the single existing device; consider using B<update-device>  for this usage.

  Attach a new disk device to the domain.
  I<source>  and I<target>  are paths for the files and devices.
-I<driver>  can be I<file>, I<tap>  or I<phy>  depending on the kind of access.
+I<driver>  can be I<file>, I<tap>  or I<phy>  for the Xen hypervisor depending on
+the kind of access or I<qemu>  for the QEMU emulator.

s/access or/access; or/

ACK with that fixed, so I pushed.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]