[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"



On 09/20/2011 11:00 AM, Daniel P. Berrange wrote:
The problem is that with doing virStreamRecv(), we will put a fake call
on the queue. We only want to signal completion of those fake calls.
This fake call should have been set to have status VIR_NET_CONTINUE
but we forgot that. So I think we need this instead:

Yes, that analysis makes more sense, but I agree that:

We will need to Dave Allen to confirm that his  console program does not
get a regression with this change added.

we need testing before I give ACK.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]