[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: using correct function to reboot guest.



I got that mean. Thanks for your reply!

On 2011年09月21日 18:27, Daniel P. Berrange wrote:
On Wed, Sep 21, 2011 at 05:53:31PM +0800, xuhj linux vnet ibm com wrote:
From: Xu He Jie<xuhj linux vnet ibm com>


Signed-off-by: Xu He Jie<xuhj linux vnet ibm com>
---
  src/qemu/qemu_driver.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f4ee4c3..b0c9c02 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -1567,7 +1567,7 @@ static int qemuDomainReboot(virDomainPtr dom, unsigned int flags) {
          }

          qemuDomainObjEnterMonitor(driver, vm);
-        ret = qemuMonitorSystemPowerdown(priv->mon);
+        ret = qemuMonitorSystemReset(priv->mon);
          qemuDomainObjExitMonitor(driver, vm);

          priv->fakeReboot = true;
NACK.

The virDomainReboot() API semantics are to perform a *graceful*
reboot of the guest. ie, the guest OS shuts down normally, and
then does a warm reboot of the virtual machine.


The system_reset monitor command does an *immediate* reset of
the virtual machine, without any guest shutdown.


If you want to expose this capability, then it should be done
via a new API.  virDomainReset(), or by adding a new flag like
VIR_DOMAIN_REBOOT_IMMEDIATE to the existing API.

Regards,
Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]