[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix synchronous reading of stream data



On 09/21/2011 07:54 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange redhat com>

commit 984840a2c292402926ad100aeea33f8859ff31a9 removed the
notification of waiting calls when VIR_NET_CONTINUE messages
arrive. This was to fix the case of a virStreamAbort() call
being prematurely notified of completion.

The problem is that sometimes there are dummy calls from a
virStreamRecv() call waiting that *do* need to be notified.

These dummy calls should have a status VIR_NET_CONTINUE. So
re-add the notification upon VIR_NET_CONTINUE, but only if
the waiter also has a status of VIR_NET_CONTINUE.

* src/rpc/virnetclient.c: Notify waiting call if stream data
   arrives
* src/rpc/virnetclientstream.c:  Mark dummy stream read packet
   with status VIR_NET_CONTINUE
---
  src/rpc/virnetclient.c       |   10 ++++++++++
  src/rpc/virnetclientstream.c |    1 +
  2 files changed, 11 insertions(+), 0 deletions(-)

ACK.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]