[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5



On 09/21/2011 06:28 AM, Eric Blake wrote:
+++ libvirt-0.9.5.new/tools/virsh.c 2011-09-21 13:56:17.000000000 +0200
@@ -13916,8 +13916,8 @@ vshCmddefGetData(const vshCmdDef *cmd, u
opt =&cmd->opts[i];
if (opt->type != VSH_OT_ARGV) {
*opts_need_arg&= ~(1<< i);
- *opts_seen |= 1<< i;
}
+ *opts_seen |= 1<< i;
return opt;

Thanks for the report, but reverting this change would break
snapshot-create-as diskspec parsing.

I'll have to come up with a proper fix that works with both commands.

Got it. Unfortunately, it was a bit more than moving one line, although your patch was indeed part of my solution. Fortunately, I played nicely and enhanced the test suite, to ensure we can't regress in the future.
https://www.redhat.com/archives/libvir-list/2011-September/msg00847.html

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]