[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Do not ignore the specified flags for cmdSaveImageDefine



On 09/22/2011 06:40 AM, Osier Yang wrote:
---
  tools/virsh.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 4b9e662..02db278 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2346,7 +2346,7 @@ cmdSaveImageDefine(vshControl *ctl, const vshCmd *cmd)
      if (virFileReadAll(xmlfile, 8192,&xml)<  0)
          goto cleanup;

-    if (virDomainSaveImageDefineXML(ctl->conn, file, xml, 0)<  0) {
+    if (virDomainSaveImageDefineXML(ctl->conn, file, xml, flags)<  0) {

ACK. I'd also add to the commit message, to mention that the bug was introduced in commit 42c52d53c

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]