[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] daemon: Don't remove pidfiles in init scripts



On 09/26/2011 12:17 PM, Peter Krempa wrote:
Init scripts removed pid file of the daemon. Removing pid files may be
harmful as new api for crash-safe pidfiles is used (introduced by
c8a3a26).
---
  daemon/libvirtd.init.in |    1 -
  daemon/libvirtd.upstart |    4 ----
  2 files changed, 0 insertions(+), 5 deletions(-)

ACK - now that the patch has been pruned down in effect, it is easier to say that this particular patch is correct (although harder to say whether it is comprehensive, or whether we will yet end up writing more patches for init script behaviors).

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]