[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] API to deal with storage pool(s)



On Tue, Sep 27, 2011 at 11:40:45AM +0800, Lei Li wrote:
> On 09/27/2011 06:19 AM, Zeeshan Ali (Khattak) wrote:
> >diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
> >index eae40a2..ff2f4cf 100644
> >--- a/libvirt-gobject/libvirt-gobject.sym
> >+++ b/libvirt-gobject/libvirt-gobject.sym
> >@@ -14,10 +14,16 @@ LIBVIRT_GOBJECT_0.0.1 {
> >  	gvir_connection_get_stream;
> >
> >  	gvir_connection_fetch_domains;
> >+	gvir_connection_fetch_storage_pools;
> >+	gvir_connection_fetch_storage_pools_async;
> >+	gvir_connection_fetch_storage_pools_finish;
> >  	gvir_connection_get_domains;
> >+	gvir_connection_get_storage_pools;
> >  	gvir_connection_get_domain;
> >+	gvir_connection_get_storage_pool;
> >  	gvir_connection_find_domain_by_id;
> >  	gvir_connection_find_domain_by_name;
> >+	gvir_connection_find_storage_pool_by_name;
> I think It would be better to add API
> gvir_connection_find_storage_pool_by_id also to keep consistence
> with domain.

Domains have 3 unique identifiers, ID, name & UUID. Storage pools
however only have 2 identifiers, name & UUID. This is why there is
no need for a  gvir_connection_find_storage_pool_by_id here (the
main libvirt API also skips this method)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]