[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: add return value check



On 09/28/2011 02:00 AM, ajia redhat com wrote:
From: Alex Jia<ajia redhat com>

* src/qemu/qemu_migration.c: if 'vmdef' is NULL, the function
   virDomainSaveConfig still dereferences it, it doesn't make
   sense, so should add return value check to make sure 'vmdef'
   is non-NULL before calling virDomainSaveConfig, in addition,
   in order to debug later, also should record error information
   into log.

Signed-off-by: Alex Jia<ajia redhat com>
---
  src/qemu/qemu_migration.c |    5 ++++-
  1 files changed, 4 insertions(+), 1 deletions(-)

ACK and pushed, after fixing your trailing whitespace bug that 'make syntax-check' tripped on.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]