[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 2/2] conf: allow fuzz in XML with cur balloon > max

On 03/31/2012 10:22 AM, Zhou Peng wrote:
> Thank you!
> ACK patch serials
> On Sat, Mar 31, 2012 at 11:33 PM, Eric Blake <eblake redhat com> wrote:
>> Commit 1b1402b introduced a regression.  Since older libvirt versions
>> would silently round memory up (until the previous patch), but populated
>> current memory based on querying the guest, it was possible to have
>> dumpxml show cur > max by the amount of the rounding.  For example, if
>> a user requested 1048570 KiB memory (just shy of 1GiB), the qemu
>> driver would actually run with 1048576 KiB, and libvirt 0.9.10 would
>> output a current that was 6KiB larger than the maximum.  Situations
>> where this could have an impact include, but are not limited to,
>> migration from old to new libvirt, managedsave in old libvirt and
>> start in new libvirt, snapshot creation in old libvirt and revert in
>> new libvirt - without this patch, the new libvirt would reject the
>> VM because of the rounding discrepancy.

I've gone ahead and pushed this, since it will avoid regressions when
0.9.11 is released.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]