[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/10] Fix broken linkage of libvirt_driver_nodedev.la



On 04/02/2012 01:57 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> libvirt_driver_nodedev.la should not link against either
> libvirt_util.la or gnulib.la, since libvirt.so brings
> in those deps.
> 
> * src/Makefile.am: Fix broken linkage of libvirt_driver_nodedev.la
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/Makefile.am |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

While the series as a whole should not be applied until post-release, I
think this one is small enough to qualify as correct, if you'd like to
push it out-of-order now.

ACK.

> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 5bc5b58..999a48a 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -987,9 +987,7 @@ libvirt_driver_nodedev_la_SOURCES = $(NODE_DEVICE_DRIVER_SOURCES)
>  libvirt_driver_nodedev_la_CFLAGS = \
>  		-I$(top_srcdir)/src/conf $(AM_CFLAGS)
>  libvirt_driver_nodedev_la_LDFLAGS = $(AM_LDFLAGS)
> -libvirt_driver_nodedev_la_LIBADD =       \
> -		libvirt_util.la          \
> -		../gnulib/lib/libgnu.la
> +libvirt_driver_nodedev_la_LIBADD =
>  
>  if HAVE_HAL
>  libvirt_driver_nodedev_la_SOURCES += $(NODE_DEVICE_DRIVER_HAL_SOURCES)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]