[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Start nested job in qemuDomainCheckEjectableMedia



On Mon, Apr 02, 2012 at 09:49:38 -0600, Eric Blake wrote:
> On 04/02/2012 08:20 AM, Jiri Denemark wrote:
> > Originally, qemuDomainCheckEjectableMedia was entering monitor with qemu
> > driver lock. Commit 2067e31bf97667eab9f111b496f5e9a44e827c5b, which I
> > made to fix that, revealed another issue we had (but didn't notice it
> > since the driver was locked): we didn't set nested job when
> > qemuDomainCheckEjectableMedia is called during migration. Thus the
> > original fix I made was wrong.
> > ---
> > 
> > I'll try to come up with something to help avoid such issues in the future.
> > 
> >  src/qemu/qemu_driver.c  |    5 ++++-
> >  src/qemu/qemu_hotplug.c |   12 +++++++-----
> >  src/qemu/qemu_hotplug.h |    4 +++-
> >  src/qemu/qemu_process.c |    2 +-
> >  4 files changed, 15 insertions(+), 8 deletions(-)
> 
> ACK.

Pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]