[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] use qemu's dump-guest-meory when vm uses host device



At 04/03/2012 08:46 AM, Eric Blake Wrote:
> On 04/02/2012 06:23 PM, Wen Congyang wrote:
>>>
>>> Why are we bothering with a text implementation?  We know that the
>>> feature is only present if you have qemu 1.1 or later (assuming that
>>> qemu-devel did apply your series adding the monitor command), and
>>> therefore we know that we have QMP, so we should only implement this for
>>> JSON and not bother with the text monitor.
>>>
>>
>> In most cases, the libvirt is built with json. But if the libvirt is built
>> without json, we will use text monitor.
> 
> If libvirt is built without json, it will die a horrible death on any
> qemu newer than 0.15, thanks to commit 6e769eba.  You can safely assume
> that a qemu 1.1 feature implies that libvirt was compiled with json
> support.  The _only_ situation that requires the text monitor is when
> building libvirt for RHEL 5 where qemu is still stuck at 0.10 and where
> JSON libraries do not exist.  I suspect no one will be backporting the
> new dump-guest-monitor command to RHEL 5.
> 

I see this commit now. So I agree with removing text monitor support now.

Thanks for point it out.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]