[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API PATCH] Added screenshot test



On 04/03/2012 09:34 PM, Peter Krempa wrote:
On 04/02/2012 08:18 PM, Martin Kletzander wrote:
This patch adds a test that obtains a screenshot of a domain and saves
it in a file.

Maybe we shoud later on modify this or add another test to allow comparing the returned image file against a pre-defined pattern, so we could actualy check if the complete stack including the OS, qemu, video drivers and libvirt's streams work.

Looks good, but I'm not a very experienced Pythonist, so if somebody else (Guannan?) could have a quick look and confirm my ACK before pushing.

Peter

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

         Thanks for the review.
         pushed.

         Guannan Ren


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]