[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1



On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote:
> Hello,
> 
> On Tuesday 27 March 2012 18:30:17 Guido Günther wrote:
> > On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote:
> > >   As scheduled, we are entering the freeze for 0.9.11.
> ...
> > >  Please give it a try ! Stability and portability feedback are really
> > > welcome as we didn't had a release in Feb and the risk of having
> > > something messed up is slightly higher than usual !
> >
> > Looks good so far on Debian's autobuilders:
> >
> > 	https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental
> 
> Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52, 
> gcc 4.4.5-8.) fails with
>   CC     libvirt_util_la-virnetdevbandwidth.lo
> util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a 
> function)
> 
> The following patch fixes that for me:
> --- a/src/util/virnetdev.c
> +++ b/src/util/virnetdev.c
> @@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname 
> ATTRIBUTE_UNUSED,
>      return -1;
>  }
>  #endif /* !__linux__ */
> -#if defined(__linux__) && defined(HAVE_LIBNL)
> +#if defined(__linux__) && defined(HAVE_LIBNL) && defined(IFLA_VF_MAX)

This looks reasonable to me since this isn't available in Debian
Squeeze's kernel headers and I don't think it's worth a separate
configure check since we'd only check for IFLA_VF_MAX there.
Cheers,
 -- Guido

>  
>  static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
>      [IFLA_VF_MAC]       = { .type = NLA_UNSPEC,
> 
> I also have to explicitly disable -Werror (error about 'const', 'pure' and an 
> undeclared 'inline' function in netlink/object.h), virtualport and 
> macvtap(also IFLA_VF_*), since configure doesn't disable them automatically:
> ./configure --without-macvtap --disable-werror --without-virtualport
> 
> Without those options I get:
> ...
> checking whether compiler handles -Wno-suggest-attribute=pure... yes
> checking whether compiler handles -Wno-suggest-attribute=const... yes
> ...
> checking whether to compile with macvtap support... yes
> checking whether MACVLAN_MODE_PASSTHRU is declared... no
> checking whether to compile with virtual port support... no
> checking for LIBNL... yes
> 
> There was some discussion some time ago on libvirt about puting the check for 
> IFLA_VF_* in configure instead of in the *.c files, but I haven't found a 
> patch yet.
> 
> Sincerely
> Philipp
> -- 
> Philipp Hahn           Open Source Software Engineer      hahn univention de
> Univention GmbH        be open.                       fon: +49 421 22 232- 0
> Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
>                                                    http://www.univention.de/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]