[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] Split config files & daemon off from main daemon RPM



On 04/03/2012 06:48 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Take the libvirt RPM and split it into three pieces
> 
>  - libvirt-daemon - libvirtd & other mandatory bits for its operation
>  - libvirt-daemon-config-network - the virbr0 config definition
>  - libvirt-daemon-config-nwfilter - the firewall config rules
> 
> For backwards compatibility with existing installs / application RPM
> deps, the 'libvirt' RPM is retained, but will have a dependancy on

s/dependancy/dependency/

> the 3 new RPMs.
> ---
>  libvirt.spec.in |  313 ++++++++++++++++++++++++++++++++-----------------------
>  1 files changed, 182 insertions(+), 131 deletions(-)

Large, but looks sane.  In particular, you shuffled the %files docs
section up, which made the last part a bit harder to read; perhaps you
could have redone patch 1/8 to stick %files docs in that area to begin
with, but it's not worth a rebase now.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]