[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms



On Wed, Apr 04, 2012 at 13:47:57 +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> linuxNodeInfoCPUPopulate is not built on Mingw32 so
> should be in libvirt_linux.syms, not libvirt_private.syms
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/libvirt_linux.syms |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms
> index 018c892..2258739 100644
> --- a/src/libvirt_linux.syms
> +++ b/src/libvirt_linux.syms
> @@ -6,3 +6,6 @@
>  # stats_linux.h
>  linuxDomainInterfaceStats;
>  xenLinuxDomainBlockStats;
> +
> +# nodeinfo.h
> +linuxNodeInfoCPUPopulate;

Both subject and commit message confused me a bit since they are misleading.
The symbol is not really moved since it was missing from any *.syms in the
first place.

ACK to adding it to libvirt_linux.syms, though.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]