[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions



On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > ---
> > >  If this looks correct I'll have a look at libvirt-glib and
> > > libvirt-gobject too.
> > 
> > Doing this would break ABI. We should just make sure future symbols
> > are added in the right place
> 
> I thought that until we decide we'll attempt to be ABI stable, we'd be
> raising the symbols version number before every release if there has been
> any new symbols, thus breaking ABI. It seems this hasn't been done in a
> while :-/

So what about the attached patch. 0.0.8 didn't introduce new symbols yet
so I went for 0.0.7.
Cheers,
 -- Guido
>From 1ad4c24bdb93f57f14f34067ecdfea129751f6d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx sigxcpu org>
Date: Wed, 11 Apr 2012 13:17:00 +0200
Subject: [libvirt-glib] Raise symbol version number

since new symbols were introduced since 0.0.4
---
 libvirt-gconfig/libvirt-gconfig.sym |    2 +-
 libvirt-glib/libvirt-glib.sym       |    2 +-
 libvirt-gobject/libvirt-gobject.sym |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym
index 717c3c9..2378a3c 100644
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GCONFIG_0.0.4 {
+LIBVIRT_GCONFIG_0.0.7 {
   global:
 	gvir_config_init_check;
 	gvir_config_init;
diff --git a/libvirt-glib/libvirt-glib.sym b/libvirt-glib/libvirt-glib.sym
index bb8fa34..53b8907 100644
--- a/libvirt-glib/libvirt-glib.sym
+++ b/libvirt-glib/libvirt-glib.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GLIB_0.0.4 {
+LIBVIRT_GLIB_0.0.7 {
   global:
         gvir_init;
         gvir_init_check;
diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
index 460280b..64c91cc 100644
--- a/libvirt-gobject/libvirt-gobject.sym
+++ b/libvirt-gobject/libvirt-gobject.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GOBJECT_0.0.4 {
+LIBVIRT_GOBJECT_0.0.7 {
   global:
         gvir_init_object;
         gvir_init_object_check;
-- 
1.7.9.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]