[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers



On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote:
> On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > What would _USB2 do? Add an _EHCI controller, plus either
> > _PIIX3_UHCI or _PIIX4_UHCI?
> 
> From what I remember Hans told me, all the 4 ehci + uhci companions
> controllers are needed for a proper USB2 setup.
> 
> I suggest an enum value such as
> CONFIG_DOMAIN_SETUP_USB_CONTROLLERS_USB2 for default USB2 setup (using
> the ICH9 controllers, but could be changed someday perhaps)

Ah ok, you want an enum for future-safety, not because you have a specific
usecase in mind? I thought you already wanted to support various cases with
this enum.
My initial reaction is that one default usb setup (which can be vary
depending on what properties were set on the domain) should be enough and
that the enum is not needed, especially since more sophisticated setups can
be achieved using the "raw" API. But I think years of libvirt development
disagree with my initial reaction ;)

Christophe

Attachment: pgp9pdymgSSdO.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]