[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS



On 12.04.2012 13:16, Laine Stump wrote:
> On 04/11/2012 04:21 PM, Laine Stump wrote:
>> ACK to the idea, but NACK to the exact placement of the fix.
> 
> 
> On further examination (and actually doing a couple tests), I withdraw
> my NACK on the placement. I had mixed up usage of qemuOpenFile and
> virFileOpen in my memory - qemuOpenFile already hardly ever cares about
> the ownership of a file it opens, and even when it does, it always wants
> it to be owned by root (well, actually getuid()).
> 
> So, although putting the fix in the place I suggested does work, my
> reasoning was flawed and your original position also works properly, as
> well as keeping the logic for setting the FORCE_OWNER flag in one place
> - ACK.
> 
> Sorry for the noise :-)

Not at all. In fact, I find this useful as somebody else has tested it.

Pushed. Thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]