[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 18/18] blockjob: wire up qemu and RPC for block copy



On Mon, Apr 09, 2012 at 21:52:27 -0600, Eric Blake wrote:
> Almost trivial; the trick was dealing with the fact that we're
> stuck with 'unsigned long bandwidth' due to earlier design
> decisions.  Also, prefer the correct flag names (although we
> intentionally chose the _SHALLOW and _REUSE_EXT values to be
> equal, to allow for loose handling in our code).
> 
> * src/remote/remote_protocol.x (remote_domain_block_copy_args):
> New struct.
> * src/remote/remote_driver.c (remote_driver): Use it.
> * src/rpc/gendispatch.pl (name_to_ProcName): Cater to legacy
> bandwidth type.
> * src/remote_protocol-structs: Regenerate.
> * src/qemu/qemu_driver.c (qemuDriver): Wire up driver callback.
> (qemuDomainBlockCopy): Use preferred flag names.
> ---
>  src/qemu/qemu_driver.c       |   13 +++++++------
>  src/remote/remote_driver.c   |    1 +
>  src/remote/remote_protocol.x |   12 +++++++++++-
>  src/remote_protocol-structs  |    9 +++++++++
>  src/rpc/gendispatch.pl       |    1 +
>  5 files changed, 29 insertions(+), 7 deletions(-)

Looks OK.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]