[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases



s/sharing in/sharing among/, but given it's already
pushed. let's live with it.

On 2012年04月10日 21:38, Guannan Ren wrote:
     sharedmod.py
---
  sharedmod.py |   16 ++++++++++++++++
  1 files changed, 16 insertions(+), 0 deletions(-)
  create mode 100644 sharedmod.py

diff --git a/sharedmod.py b/sharedmod.py
new file mode 100644
index 0000000..8af26d8
--- /dev/null
+++ b/sharedmod.py
@@ -0,0 +1,16 @@
+# This is a module for variable sharing across testcases during
+# running. You have to import it in each of testcases which want
+# to share data. The framwork have already set {'conn': connobj}
+# in libvirtobj dictionary for use in testcases.
+
+# The libvirtobj dictionary is only set and used by framework

Any checking? I.e could testcase r/w it too?

+# in testcases you could use sharedmod.libvirtobj['conn'] to get
+# the connection object in libvirt.py, you need not to close it,

IMHO "need not" should be "should never". How about the
follow up use of connection if it's already closed, reopen one
again?

+# the framework do it.

<snip>
The framwork have already set {'conn': connobj}
+# in libvirtobj dictionary for use in testcases.
+
</snip>

The comment above should resides here.

+libvirtobj = {}
+
+# shared variables for customized use in testcases
+# set variable: sharedmod.data['my_test_variable'] = 'test_value'
+# check the variable: sharedmod.data.has_key('my_test_variable')
+# get the varialbe: sharedmod.data.get('my_test_variable', 'test_variable_default_value')

From my p.o.v, "libvirtobj" is a confused name, also "data" is
not enough to tell what the meaning is. How about use
"framework_shares" and "case_shares" instead?

And implement get/set/has functions for both "framework_shares"
and "case_shares", but not access them directly. e.g.

def case_shares_get(key):
    pass

def case_shares_set(key, value):
    pass

def case_shares_has(key)
    pass

Even perhaps a class is good.

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]