[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API PATCH 3/3] repo: cleanup clean functions that are not used



On 2012年04月16日 14:11, Guannan Ren wrote:
---
  repos/domain/attach_disk.py                        |    4 ----
  repos/domain/autostart.py                          |    4 ----
  repos/domain/balloon_memory.py                     |    4 ----
  repos/domain/blkstats.py                           |    4 ----
  repos/domain/console_mutex.py                      |    4 ----
  repos/domain/cpu_affinity.py                       |    4 ----
  repos/domain/cpu_topology.py                       |    5 -----
  repos/domain/define.py                             |    4 ----
  repos/domain/destroy.py                            |    4 ----
  repos/domain/detach_disk.py                        |    4 ----
  repos/domain/eventhandler.py                       |    4 ----
  repos/domain/ifstats.py                            |    4 ----
  repos/domain/install_linux_check.py                |    5 -----
  repos/domain/restore.py                            |    4 ----
  repos/domain/resume.py                             |    4 ----
  repos/domain/shutdown.py                           |    4 ----
  repos/domain/start.py                              |    4 ----
  repos/domain/suspend.py                            |    4 ----
  repos/domain/undefine.py                           |    4 ----
  repos/libvirtd/restart.py                          |    5 -----
  .../multiple_thread_block_on_domain_create.py      |   14 --------------
  repos/snapshot/delete.py                           |    4 ----
  repos/snapshot/file_flag.py                        |    4 ----
  repos/snapshot/flag_check.py                       |    4 ----
  repos/snapshot/internal_create.py                  |    4 ----
  repos/snapshot/revert.py                           |    5 -----
  repos/snapshot/snapshot_list.py                    |    5 -----
  repos/storage/build_dir_pool.py                    |    3 ---
  28 files changed, 0 insertions(+), 126 deletions(-)

diff --git a/repos/domain/attach_disk.py b/repos/domain/attach_disk.py
index 4385df7..9d8426d 100644
--- a/repos/domain/attach_disk.py
+++ b/repos/domain/attach_disk.py
@@ -99,7 +99,3 @@ def attach_disk(params):
          return 1

      return 0
-
-def attach_disk_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/autostart.py b/repos/domain/autostart.py
index 930a04b..1906706 100644
--- a/repos/domain/autostart.py
+++ b/repos/domain/autostart.py
@@ -73,7 +73,3 @@ def autostart(params):
          return 1

      return 0
-
-def autostart_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/balloon_memory.py b/repos/domain/balloon_memory.py
index 7cef074..25b8318 100644
--- a/repos/domain/balloon_memory.py
+++ b/repos/domain/balloon_memory.py
@@ -259,7 +259,3 @@ def balloon_memory(params):
      if count:
          return 1
      return 0
-
-def balloon_memory_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/blkstats.py b/repos/domain/blkstats.py
index 1500a1a..a208887 100644
--- a/repos/domain/blkstats.py
+++ b/repos/domain/blkstats.py
@@ -66,7 +66,3 @@ def blkstats(params):
          return 1

      return 0
-
-def blkstats_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/console_mutex.py b/repos/domain/console_mutex.py
index 409861b..c67aec6 100644
--- a/repos/domain/console_mutex.py
+++ b/repos/domain/console_mutex.py
@@ -87,7 +87,3 @@ def console_mutex(params):
          logger.info("Done")

      return ret
-
-def console_mutex_clean(params):
-    """clean testing environment"""
-    pass
diff --git a/repos/domain/cpu_affinity.py b/repos/domain/cpu_affinity.py
index 833cfd2..1332c7e 100644
--- a/repos/domain/cpu_affinity.py
+++ b/repos/domain/cpu_affinity.py
@@ -280,7 +280,3 @@ def cpu_affinity(params):
      if retflag:
          return 1
      return 0
-
-def cpu_affinity_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/cpu_topology.py b/repos/domain/cpu_topology.py
index 2caf919..af41f62 100644
--- a/repos/domain/cpu_topology.py
+++ b/repos/domain/cpu_topology.py
@@ -199,8 +199,3 @@ def cpu_topology(params):
         return 1

      return 0
-
-def cpu_topology_clean(params):
-    """clean testing enviorment"""
-    return 0
-
diff --git a/repos/domain/define.py b/repos/domain/define.py
index 29d2c15..9d3b2eb 100644
--- a/repos/domain/define.py
+++ b/repos/domain/define.py
@@ -92,7 +92,3 @@ def define(params):
          return 1

      return 0
-
-def define_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/destroy.py b/repos/domain/destroy.py
index 9d71835..c41f0f8 100644
--- a/repos/domain/destroy.py
+++ b/repos/domain/destroy.py
@@ -91,7 +91,3 @@ def destroy(params):
              return 1

      return 0
-
-def destroy_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/detach_disk.py b/repos/domain/detach_disk.py
index ddba2ca..1b0b7f9 100644
--- a/repos/domain/detach_disk.py
+++ b/repos/domain/detach_disk.py
@@ -75,7 +75,3 @@ def detach_disk(params):
          return 1

      return 0
-
-def detach_disk_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/eventhandler.py b/repos/domain/eventhandler.py
index 1c029eb..4eec6e9 100644
--- a/repos/domain/eventhandler.py
+++ b/repos/domain/eventhandler.py
@@ -241,7 +241,3 @@ def eventhandler(params):

      loop_stop(conn)
      return 0
-
-def eventhandler_clean(params):
-    """cleanup the testing environment"""
-    pass
diff --git a/repos/domain/ifstats.py b/repos/domain/ifstats.py
index c809809..dd6c193 100644
--- a/repos/domain/ifstats.py
+++ b/repos/domain/ifstats.py
@@ -81,7 +81,3 @@ def ifstats(params):
          return 1

      return 0
-
-def ifstats_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/install_linux_check.py b/repos/domain/install_linux_check.py
index 11f4086..1c27fc1 100644
--- a/repos/domain/install_linux_check.py
+++ b/repos/domain/install_linux_check.py
@@ -180,8 +180,3 @@ def install_linux_check(params):
              return Test_Result

      return Test_Result
-
-def install_linux_check_clean(params):
-    """ clean testing environment """
-    pass
-
diff --git a/repos/domain/restore.py b/repos/domain/restore.py
index acc0b9f..ab0900f 100644
--- a/repos/domain/restore.py
+++ b/repos/domain/restore.py
@@ -85,7 +85,3 @@ def restore(params):
          return 1

      return 0
-
-def restore_clean(params):
-    """ clean the testing environment """
-    pass
diff --git a/repos/domain/resume.py b/repos/domain/resume.py
index 6110f28..85237f7 100644
--- a/repos/domain/resume.py
+++ b/repos/domain/resume.py
@@ -57,7 +57,3 @@ def resume(params):

      logger.info("PASS")
      return 0
-
-def resume_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/shutdown.py b/repos/domain/shutdown.py
index 33a6153..3b97abc 100644
--- a/repos/domain/shutdown.py
+++ b/repos/domain/shutdown.py
@@ -69,7 +69,3 @@ def shutdown(params):
          logger.info("domain %s shutdown successfully" % domname)

      return 0
-
-def shutdown_clean(params):
-    """ clean the testing environment """
-    pass
diff --git a/repos/domain/start.py b/repos/domain/start.py
index 3bddfe5..f319c2e 100644
--- a/repos/domain/start.py
+++ b/repos/domain/start.py
@@ -96,7 +96,3 @@ def start(params):

      logger.info("PASS")
      return 0
-
-def start_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/suspend.py b/repos/domain/suspend.py
index 32295ea..1941b1c 100644
--- a/repos/domain/suspend.py
+++ b/repos/domain/suspend.py
@@ -61,7 +61,3 @@ def suspend(params):

      logger.info('PASS')
      return 0
-
-def suspend_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/domain/undefine.py b/repos/domain/undefine.py
index 465b5d1..4b1bc20 100644
--- a/repos/domain/undefine.py
+++ b/repos/domain/undefine.py
@@ -43,7 +43,3 @@ def undefine(params):
          return 1

      return 0
-
-def undefine_clean(params):
-    """ clean testing environment """
-    pass
diff --git a/repos/libvirtd/restart.py b/repos/libvirtd/restart.py
index 40f5a01..04efa8a 100644
--- a/repos/libvirtd/restart.py
+++ b/repos/libvirtd/restart.py
@@ -142,8 +142,3 @@ def restart(params):
                       libvirtd restart" % guestname)

      return 0
-
-def restart_clean(params):
-    """ clean testing environment """
-    pass
-
diff --git a/repos/regression/multiple_thread_block_on_domain_create.py b/repos/regression/multiple_thread_block_on_domain_create.py
index 2672ff7..38030c2 100644
--- a/repos/regression/multiple_thread_block_on_domain_create.py
+++ b/repos/regression/multiple_thread_block_on_domain_create.py
@@ -147,17 +147,3 @@ def multiple_thread_block_on_domain_create(params):

      conn.close()
      return 0
-
-
-
-
-
-
-
-
-
-
-
-
-
-

Please create a separate patch for this. It's of different purpose.
Need a v2.

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]