[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemuProcessStart: Switch to flags instead of bunch booleans



On 16.04.2012 17:26, Daniel P. Berrange wrote:
> On Mon, Apr 16, 2012 at 05:09:59PM +0200, Michal Privoznik wrote:
>> Currently, we have 3 boolean arguments we have to pass
>> to qemuProcessStart(). As libvirt grows it is harder and harder
>> to remember them and their position. Therefore we should
>> switch to flags instead.
>> ---
>> diff to v1:
>> -fix a test for START_PAUSED flag
>>
>>  src/qemu/qemu_driver.c    |   45 +++++++++++++++++++++++++++++----------------
>>  src/qemu/qemu_migration.c |    7 ++++---
>>  src/qemu/qemu_process.c   |   21 +++++++++++++--------
>>  src/qemu/qemu_process.h   |   12 ++++++++----
>>  4 files changed, 54 insertions(+), 31 deletions(-)
>>

> 
> 
> ACK, that's better now
> 
> 
> Daniel

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]