[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC



On 04/16/2012 09:03 PM, Osier Yang wrote:
> On 2012年04月17日 10:44, Eric Blake wrote:
>> On 04/16/2012 08:05 PM, Osier Yang wrote:
>>>> [09:31]    danpb1    eblake: the fact that we see that error message
>>>> suggest a
>>>> pre-existing bug in the test suite - the XML being used to define the
>>>> test domain is missing a UUID
>>>> [09:31]    danpb1    eblake: so the 2 repeated defines get different
>>>> auto-generated UUIDs&   thus violate the uniqueness check
>>>> [09:31]    danpb1    eblake: i expect if you fixed that problem, then
>>>> you'd
>>>> now see the 'define' operation actually suceed
>>>
>>> Not true, there is UUID in the dumped xml:
>>
>> A generated UUID - that is, we have a latent bug, in that since we
>> aren't locking down a specific UUID, the generated one is different each
>> time, and the test failed (as expected), but for the wrong reason
>> (mismatch in UUID, instead of the intended failure due to a cpuset
>> syntax error).
>>
> 
> Yeah, just because the cpuset syntax error comes up earlier before
> the UUID checking. I post a patch to set the fixed UUID for the
> objects which support UUID in test driver, see the attachment.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]