[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [test-API] Add one space between shebang and following interpreter

On Tue, 17 Apr 2012, Osier Yang wrote:

up top, so it is not missed:
Executive summary: please reject this path -- details infra ...

We want it looks better. Isn't it? :-)
activityfilter.py                                  |    2 +-
 ... snippety ...
utils/xmlgenerator.py                              |    2 +-
116 files changed, 116 insertions(+), 116 deletions(-)

diff --git a/activityfilter.py b/activityfilter.py
index 1326948..4c26fbd 100644
--- a/activityfilter.py
+++ b/activityfilter.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#! /usr/bin/env/ python

What in the world?

1.) I thought that /usr/bin/env python path determination was depreciated at Red Hat

2.) It may 'want it looks better' to some eyes, but it simply looks ** wrong ** to my tired old she-bang eyes [1]

'There have been rumors that some old versions of UNIX look for the normal shebang followed by a space and a slash ("#! /"), but this appears to be untrue. [29]'

Please reject this 'bike-shedding' patch

-- Russ herrold

[1] http://en.wikipedia.org/wiki/Shebang_%28Unix%29
[29] http://www.in-ulm.de/~mascheck/various/shebang/#details

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]