[libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

Eric Blake eblake at redhat.com
Tue Apr 17 17:49:22 UTC 2012


On 04/17/2012 11:45 AM, Guannan Ren wrote:
>     The result is indeterminate for NULL argument to python
>     functions as follows. It's better to return negative value in
>     these situations.
> 
>     PyObject_IsTrue will segfault if the argument is NULL
>     PyFloat_AsDouble(NULL) is -1.000000
>     PyLong_AsUnsignedLongLong(NULL) is 0.000000
> ---
>  python/typewrappers.c |   26 +++++++++++++++++++++++---
>  1 files changed, 23 insertions(+), 3 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120417/386108b8/attachment-0001.sig>


More information about the libvir-list mailing list