[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a memory leak



On 04/17/2012 03:03 PM, Eric Blake wrote:
On 04/17/2012 12:55 PM, Stefan Berger wrote:

      }

+    dest->type = src->type;
+
ACK.  No good writing into a union if you forget to also update the
discriminator to say which branch of the union is active.  The missing
assignment definitely explains the memory leak.

Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]