[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API 09/10] Rename and modify the syntax of BUGSKIP

On 04/18/2012 01:49 PM, Osier Yang wrote:
Skipping only step(s) of a test case doesn't make sense, e.g.
there is a bug of domain defining, if we only skip the "domain:define"
in all test cases, that means all the followup steps (e.g. domain
start, checking) of all of the test cases use "domain:define" will
run forward blindly. That's really not correct.

This patch modify the syntax so that it skip the whole test case
due to either a bug or lacking of testing environment. And thus the
name is changed into "SKIP".

No codes to support the new syntax yet, but it's fine, as we still
don't support to execute all test cases in a bundle. And the syntax
to skip step(s) in test cases should be just destroyed. There will
be follow up patches to destroy the codes to skip test steps in
test cases, and patches to support to execute all test cases
in a bundle and the new skipping syntax.
  BUGSKIP |    4 ----
  SKIP    |   26 ++++++++++++++++++++++++++
  2 files changed, 26 insertions(+), 4 deletions(-)
  delete mode 100644 BUGSKIP
  create mode 100644 SKIP

diff --git a/BUGSKIP b/BUGSKIP
deleted file mode 100644
index 70972d4..0000000
+++ /dev/null
@@ -1,4 +0,0 @@
-# This is a file for skipping a testcase due to an already bug in bugzilla
-# example as follows
-# casename:domain:destroy id:12345 bugzilla:http://bugzilla.redhat.com/bugid description:"This is a bug"
diff --git a/SKIP b/SKIP
new file mode 100644
index 0000000..442e8ca
--- /dev/null
+++ b/SKIP
@@ -0,0 +1,26 @@
+# Skip cases due to existed bug, or lacking of testing environment.
+# The format:
+# {
+#     case: $casename
+#     bugzilla: $bug_uri
+#     reason: $why_to_skip
+# }
+# Fields "case" and "reason" is required, "bug" is optional.
+# Example:
+# Skip case 'cases/foo.conf' due to a bug
+# {
+#     case: "cases/foo.conf",
+#     bug: http://bugzilla.redhat.com/show_bug.cgi?id=809783
+#     reason: "It's bug!",
+# }
+# Skip case due to lacking of testing environment
+# {
+#     case: "cases/bar.conf",
+#     reason: "Lacks of device"
+# }

The idea is theoretical, hard to know the full view without code patch.

I support remove BUGSKIP file, but the new file, it has a long way to go before
      commit and push.

      Guannan Ren

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]