[libvirt] [PATCH v2 6/9] pvs: add support of VNC remote display

Dmitry Guryanov dguryanov at parallels.com
Wed Apr 18 18:07:40 UTC 2012


Signed-off-by: Dmitry Guryanov <dguryanov at parallels.com>
---
 src/pvs/pvs_driver.c |   65 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 65 insertions(+), 0 deletions(-)

diff --git a/src/pvs/pvs_driver.c b/src/pvs/pvs_driver.c
index a4d9ecf..2886736 100644
--- a/src/pvs/pvs_driver.c
+++ b/src/pvs/pvs_driver.c
@@ -258,6 +258,68 @@ pvsAddDomainHardware(virDomainObjPtr dom, virJSONValuePtr jobj)
     return -1;
 }
 
+static int
+pvsAddVNCInfo(virDomainObjPtr dom, virJSONValuePtr jobj_root)
+{
+    const char *tmp;
+    unsigned int port;
+    virJSONValuePtr jobj;
+    int ret = -1;
+
+    virDomainDefPtr def = dom->def;
+
+    virDomainGraphicsDefPtr gr = NULL;
+
+    jobj = virJSONValueObjectGet(jobj_root, "Remote display");
+    if (!jobj) {
+        pvsParseError();
+        goto cleanup;
+    }
+
+    tmp = virJSONValueObjectGetString(jobj, "mode");
+    if (!tmp) {
+        pvsParseError();
+        goto cleanup;
+    }
+
+    if (STREQ(tmp, "off")) {
+        ret = 0;
+        goto cleanup;
+    }
+
+    if (VIR_ALLOC(gr) < 0)
+        goto no_memory;
+
+    if (virJSONValueObjectGetNumberUint(jobj, "port", &port) < 0) {
+        pvsParseError();
+        goto cleanup;
+    }
+
+    /* TODO: handle non-auto vnc mode */
+    gr->type = VIR_DOMAIN_GRAPHICS_TYPE_VNC;
+    gr->data.vnc.port = port;
+    gr->data.vnc.autoport = 0;
+    gr->data.vnc.keymap = NULL;
+    gr->data.vnc.socket = NULL;
+    gr->data.vnc.auth.passwd = NULL;
+    gr->data.vnc.auth.expires = 0;
+    gr->data.vnc.auth.connected = 0;
+
+    if (VIR_REALLOC_N(def->graphics, def->ngraphics + 1) < 0) {
+        virDomainGraphicsDefFree(gr);
+        goto no_memory;
+    }
+
+    def->graphics[def->ngraphics++] = gr;
+    return 0;
+
+  no_memory:
+    virReportOOMError();
+  cleanup:
+    VIR_FREE(gr);
+    return ret;
+}
+
 /*
  * Must be called with privconn->lock held
  */
@@ -397,6 +459,9 @@ pvsLoadDomain(pvsConnPtr privconn, virJSONValuePtr jobj)
     if (pvsAddDomainHardware(dom, jobj2))
         goto cleanup_unlock;
 
+    if (pvsAddVNCInfo(dom, jobj))
+        goto cleanup_unlock;
+
     virDomainObjUnlock(dom);
 
     return dom;
-- 
1.7.1




More information about the libvir-list mailing list