[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 13/23] blockjob: allow for existing files



On Mon, Apr 16, 2012 at 23:06:04 -0600, Eric Blake wrote:
> This copies some of the checks from snapshots regarding testing
> when a file already exists.  In the process, I noticed snapshots
> had hard-to-read logic, as well as a missing sanity check:
> REUSE_EXT should require the destination to already be present.
> 
> * src/qemu/qemu_driver.c (qemuDomainBlockRebase): Allow REUSE_EXT
> flag.
> (qemuDomainBlockCopy): Wire up flag, and add some sanity checks.
> (qemuDomainSnapshotDiskPrepare): Require destination on REUSE_EXT.
> ---
> 
> was 13/18 in v4
> v5: improve logic readability
> 
>  src/qemu/qemu_driver.c |   50 ++++++++++++++++++++++++++++++++++++++++++-----
>  1 files changed, 44 insertions(+), 6 deletions(-)

OK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]