[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 3/3] build: avoid strtol and strtod



On 04/19/2012 02:24 PM, Eric Blake wrote:
> Ensure we don't introduce any more lousy integer parsing in new
> code, while avoiding a scrub-down of existing legacy code.
>
> Note that we also need to enable sc_prohibit_atoi_atof (see cfg.mk
> local-checks-to-skip) before we are bulletproof, but that also
> entails scrubbing I'm not ready to do at the moment.
>
> * src/util/util.c (virStrToLong_i, virStrToLong_ui)
> (virStrToLong_l, virStrToLong_ul, virStrToLong_ll)
> (virStrToLong_ull, virStrToDouble): Mark exemptions.
> * src/util/virmacaddr.c (virMacAddrParse): Likewise.
> * cfg.mk (sc_prohibit_strtol): New syntax check.
> (exclude_file_name_regexp--sc_prohibit_strtol): Ignore files that
> I'm not willing to fix yet.
> (local-checks-to-skip): Re-enable sc_prohibit_atoi_atof.
> ---
>
> v2: no change

Then Stefan's ACK from V1 holds :-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]