[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API 07/17] Substitute _guest with _domain



On 04/20/2012 10:29 AM, Osier Yang wrote:
> On 2012年04月20日 16:17, Martin Kletzander wrote:
>> On 04/20/2012 08:46 AM, Osier Yang wrote:
>>> ---
>>>   .../en-US/Creating_a_configuration_file.xml        |   82
>>> ++++++++++----------
>>>   .../en-US/Writing_a_test_case.xml                  |   24 +++---
>>>   .../libvirt-test-API_Guide/en-US/extras/log.txt    |   18 ++--
>>>   repos/domain/domain_list.py                        |   12 ++--
>>>   repos/domain/install_linux_cdrom.py                |   18 ++--
>>>   repos/domain/install_linux_net.py                  |    8 +-
>>>   repos/domain/install_windows_cdrom.py              |    6 +-
>>>   repos/domain/update_devflag.py                     |    6 +-
>>>   8 files changed, 87 insertions(+), 87 deletions(-)
>>>
>>> diff --git
>>> a/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>> b/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>
>>> index 80ebdb1..ffac187 100644
>>> ---
>>> a/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>
>>> +++
>>> b/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>
>>> @@ -90,7 +90,7 @@ module:test_case
>>>       <example>
>>>       <title>Configuration file</title>
>>>   <programlisting>
>>> -Domain:install_guest
>>> +Domain:install_domain
>>>       guestname
>>>           rhel5u4
>>>       memory
>>> @@ -105,7 +105,7 @@ Domain:install_guest
>>>       <title>List data structure</title>
>>>   <programlisting>
>>>   [
>>> -  [{'domain:install_guest': {'guestname': 'rhel5u4', 'memory':
>>> '1024', 'vcpu': '1'}}]
>>> +  [{'domain:install_domain': {'guestname': 'rhel5u4', 'memory':
>>> '1024', 'vcpu': '1'}}]
>>
>> I'm not sure about this. The thing we're creating is a domain, but we're
>> installing a guest, am I right? (thus the "guestname" and later
>> "guestip" and so on. But I could be wrong. Also even if I'm not, the
>> question is how much we want to separate this in order to keep it
>> readable.
> 
> 
> I'm not quite sure about it either, but I would like to post the patch
> so there could be discussion, IIRC, there was discussion about the TERM
> "domain" and "guest" before too. Anyway, there should be guidelines for
> it, mixing use of both of them at liberty can just produce messy codes.
> 
> Osier

It's written in the guide: http://libvirt.org/devguide.html but I'm not
sure even after reading it. It's not _defined_ there, so we should
probably go with our gut on this one. After looking at the code with all
the patches applied, I think this could be ok, we have only few words
with guest in it and they make sense, so for the sake of stabilizing the
code asap, ACK.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]