[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API 07/17] Substitute _guest with _domain



On 04/20/2012 11:16 AM, Alex Jia wrote:
> On 04/20/2012 04:29 PM, Osier Yang wrote:
>> On 2012年04月20日 16:17, Martin Kletzander wrote:
>>> On 04/20/2012 08:46 AM, Osier Yang wrote:
>>>> ---
>>>>   .../en-US/Creating_a_configuration_file.xml        |   82
>>>> ++++++++++----------
>>>>   .../en-US/Writing_a_test_case.xml                  |   24 +++---
>>>>   .../libvirt-test-API_Guide/en-US/extras/log.txt    |   18 ++--
>>>>   repos/domain/domain_list.py                        |   12 ++--
>>>>   repos/domain/install_linux_cdrom.py                |   18 ++--
>>>>   repos/domain/install_linux_net.py                  |    8 +-
>>>>   repos/domain/install_windows_cdrom.py              |    6 +-
>>>>   repos/domain/update_devflag.py                     |    6 +-
>>>>   8 files changed, 87 insertions(+), 87 deletions(-)
>>>>
>>>> diff --git
>>>> a/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>> b/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>>
>>>> index 80ebdb1..ffac187 100644
>>>> ---
>>>> a/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>>
>>>> +++
>>>> b/docs/User_Guide/libvirt-test-API_Guide/en-US/Creating_a_configuration_file.xml
>>>>
>>>> @@ -90,7 +90,7 @@ module:test_case
>>>> <example>
>>>> <title>Configuration file</title>
>>>> <programlisting>
>>>> -Domain:install_guest
>>>> +Domain:install_domain
>>>>       guestname
>>>>           rhel5u4
>>>>       memory
>>>> @@ -105,7 +105,7 @@ Domain:install_guest
>>>> <title>List data structure</title>
>>>> <programlisting>
>>>>   [
>>>> -  [{'domain:install_guest': {'guestname': 'rhel5u4', 'memory':
>>>> '1024', 'vcpu': '1'}}]
>>>> +  [{'domain:install_domain': {'guestname': 'rhel5u4', 'memory':
>>>> '1024', 'vcpu': '1'}}]
>>>
>>> I'm not sure about this. The thing we're creating is a domain, but we're
>>> installing a guest, am I right? (thus the "guestname" and later
>>> "guestip" and so on. But I could be wrong. Also even if I'm not, the
>>> question is how much we want to separate this in order to keep it
>>> readable.
>>
>>
>> I'm not quite sure about it either, but I would like to post the patch
>> so there could be discussion, IIRC, there was discussion about the TERM
>> "domain" and "guest" before too. Anyway, there should be guidelines for
>> it, mixing use of both of them at liberty can just produce messy codes.
>>
> I feel 'domain' should be a xen terminology such as domain 0(dom0) and
> domain U(domU),
> and domU is a user domains, as usual, called a guest in kvm/qemu,
> however, it's not very
> clear such as some guys say xen guest domain :-(

I feel it a little bit different. I know I'm in no position to have a
firm stance on this subject, but let me explain what I mean.

>From my point of view, domain is a (virtual) machine. The system running
inside the VM is guest. However, there are things that might have
connection with both. This is clearly the "where do we draw the line"
kind of case. I think HW-related terms could be called 'domain' (e.g.
MAC address), which would make the SW-related called 'guest'. When it
sounds good, there is no problem with calling something 'guest domain',
but just when it feels right (and that's probably just when it means
domain, as it is the subjective noun in this case, whether "guest" is
just an adjective). I got caught in a moment and went a little deep, I
know, sorry for that.

Just my $0.02

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]