[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/2] Update Libvirt-gconfig-docs.xml



On Fri, Apr 20, 2012 at 05:13:02PM +0200, Marc-André Lureau wrote:
> I think doc should fall in the "trivial" category, unless you need
> review for spelling and correctness, ack.

I'd appreciate feedback on the docbook structural changes
(chapter/part/...) since I don't know a lot about it.
In the second patch of this series, a review of the doc for
gvir_config_domain_controller_usb_set_master would be appreciated too since
I'm not sure what startport is, and I'm not too confident about the way I
described the master/companion relationship.

Christophe

> 
> On Fri, Apr 20, 2012 at 4:06 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > It was missing most classes in the GVirConfig namespace.
> > ---
> >  docs/libvirt-gconfig/Libvirt-gconfig-docs.xml |   67 ++++++++++++++++++++++---
> >  1 file changed, 60 insertions(+), 7 deletions(-)
> >
> > diff --git a/docs/libvirt-gconfig/Libvirt-gconfig-docs.xml b/docs/libvirt-gconfig/Libvirt-gconfig-docs.xml
> > index 9719734..a05c3f3 100644
> > --- a/docs/libvirt-gconfig/Libvirt-gconfig-docs.xml
> > +++ b/docs/libvirt-gconfig/Libvirt-gconfig-docs.xml
> > @@ -9,24 +9,77 @@
> >     <title>Libvirt-gconfig Reference Manual</title>
> >   </bookinfo>
> >
> > -  <chapter>
> > +  <part>
> >     <title>Libvirt-gconfig</title>
> >     <xi:include href="xml/libvirt-gconfig-object.xml"/>
> > -    <xi:include href="xml/libvirt-gconfig-domain.xml"/>
> > +    <chapter>
> > +      <title>Domain configuration</title>
> > +      <xi:include href="xml/libvirt-gconfig-domain-address-pci.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-address-usb.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-address.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-channel.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-chardev.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-chardev-source.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-chardev-source-pty.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-chardev-source-spicevmc.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-clock.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-console.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-controller.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-controller-usb.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-device.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-disk.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-filesys.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-graphics.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-graphics-sdl.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-graphics-spice.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-graphics-vnc.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-input.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-interface.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-interface-bridge.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-interface-network.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-interface-user.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-memballoon.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-os.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-parallel.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-redirdev.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-seclabel.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-serial.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-snapshot.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-sound.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-timer.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-timer-pit.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-timer-rtc.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain-video.xml"/>
> > +      <xi:include href="xml/libvirt-gconfig-domain.xml"/>
> > +    </chapter>
> >     <xi:include href="xml/libvirt-gconfig-domain-snapshot.xml"/>
> >     <xi:include href="xml/libvirt-gconfig-interface.xml"/>
> >     <xi:include href="xml/libvirt-gconfig-network-filter.xml"/>
> >     <xi:include href="xml/libvirt-gconfig-network.xml"/>
> >     <xi:include href="xml/libvirt-gconfig-node-device.xml"/>
> >     <xi:include href="xml/libvirt-gconfig-secret.xml"/>
> > -    <xi:include href="xml/libvirt-gconfig-storage-pool.xml"/>
> > -    <xi:include href="xml/libvirt-gconfig-storage-vol.xml"/>
> > +    <chapter>
> > +      <title>Storage Configuration</title>
> > +      <xi:include href="xml/libvirt-gconfig-storage-permissions.xml"/>
> > +      <section>
> > +        <title>Storage Pools Configuration</title>
> > +        <xi:include href="xml/libvirt-gconfig-storage-pool.xml"/>
> > +        <xi:include href="xml/libvirt-gconfig-storage-pool-source.xml"/>
> > +        <xi:include href="xml/libvirt-gconfig-storage-pool-target.xml"/>
> > +      </section>
> > +      <section>
> > +        <title>Storage Volumes Configuration</title>
> > +        <xi:include href="xml/libvirt-gconfig-storage-vol.xml"/>
> > +        <xi:include href="xml/libvirt-gconfig-storage-vol-backing-store.xml"/>
> > +        <xi:include href="xml/libvirt-gconfig-storage-vol-target.xml"/>
> > +      </section>
> > +    </chapter>
> >     <xi:include href="xml/libvirt-gconfig-capabilities.xml"/>
> > -  </chapter>
> > -  <chapter id="object-tree">
> > +  </part>
> > +  <part id="object-tree">
> >     <title>Object Hierarchy</title>
> >      <xi:include href="xml/tree_index.sgml"/>
> > -  </chapter>
> > +  </part>
> >   <index id="api-index-full">
> >     <title>API Index</title>
> >     <xi:include href="xml/api-index-full.xml"><xi:fallback /></xi:include>
> > --
> > 1.7.10
> >
> > --
> > libvir-list mailing list
> > libvir-list redhat com
> > https://www.redhat.com/mailman/listinfo/libvir-list
> 
> 
> 
> -- 
> Marc-André Lureau

Attachment: pgpWqh2owrOFe.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]