[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API PATCH 2/4] don't pop out element from optional_params



On 04/25/2012 11:11 AM, Osier Yang wrote:

s/don't/Don't/

On 2012年04月24日 17:40, Guannan Ren wrote:
This a bug, if we define a testcase that use xml file such as

s/use/uses/

'storage:define_dir_pool' more than once, the pop action will
result in that the second call to the testcases fails to get

s/testcases/testcase/, s/fails/fail/

xml string in 'xmlstr = params['xml']'
Because the 'xml' element is poped out previously

Well, how about a compcat one:

Don't pop "xml" from the list, as it will still be used
afterwards.

---
  src/testcasexml.py |    5 +----
  1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/src/testcasexml.py b/src/testcasexml.py
index 742116b..8485d3d 100644
--- a/src/testcasexml.py
+++ b/src/testcasexml.py

Honestly, I'm really disappointed with the filename. :-),


       Change it as you want, it is hard for me to give a nice name :)
It is used to get the xml file (from testcase file or use the default)
       replace key words with value, pass the xml string to testcases.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]