[libvirt] [test-API PATCH v2] improve testcases after cleanup work

[Osier Yang]

On 2012年04月25日 16:27, Guannan Ren wrote:
> On 04/25/2012 04:13 PM, Osier Yang wrote:
>> On 2012年04月25日 13:23, Guannan Ren wrote:
>>> install_linux_cdrom.py: use global variable with value
>>> /var/cache/libvirt-test-API
>>> copy custom.iso into it for qemu process
>>>
>>> install_linux_check.py: use hddriver and nicdriver name
>>>
>>> network/create.py: in the case of the network with 'isolate' type
>>> we need to remove '<forward mode="NETMODE"/>'line,
>>> The bug is caused by changes on using xml files
>>>
>>> network/define.py: Same as network/create.py
>>>
>>> snapshot/delete.py: The TESTCASE_check is reserved function name for
>>> framework, so change the internal checking function
>>> to check_xml()
>>> ---
>>> repos/domain/install_linux_cdrom.py | 20 ++++++++++++++------
>>> repos/domain/install_linux_check.py | 6 +++---
>>> repos/network/create.py | 4 ++++
>>> repos/network/define.py | 6 +++++-
>>> repos/snapshot/delete.py | 6 +++---
>>> 5 files changed, 29 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/repos/domain/install_linux_cdrom.py
>>> b/repos/domain/install_linux_cdrom.py
>>> index 60d12a7..e46491b 100644
>>> --- a/repos/domain/install_linux_cdrom.py
>>> +++ b/repos/domain/install_linux_cdrom.py
>>> @@ -36,7 +36,7 @@ VM_STAT = "virsh --quiet list --all| grep
>>> \"\\b%s\\b\"|grep off"
>>> VM_DESTROY = "virsh destroy %s"
>>> VM_UNDEFINE = "virsh undefine %s"
>>>
>>> -BOOT_DIR = "/var/lib/libvirt/boot/"
>>> +BOOT_ISO_DIR = "/var/cache/libvirt-test-api"
>>
>> As replied in previous mail. We should have this in global.cfg,
>> and use it instead of create a $source_root/$guestname for each
>> guest installation.
>>
>>
>
> The variable is only used by this testcase, not by framework
> do you think it is right to set this variable in global.cfg?
>
>

Yeah, that's why it's named "global.cfg", actually many variables
defined in it are for case. e.g. $defaulthv.....

Osier