[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3] keepalive: Add ability to disable keepalive messages



On Wed, Apr 25, 2012 at 16:18:07 +0200, Peter Krempa wrote:
> The docs for virConnectSetKeepAlive() advertise that this function
> should be able to disable keepalives on negative or zero interval time.
> 
> This patch removes the check that prohibited this and adds code to
> disable keepalives on negative/zero interval.
> 
> * src/libvirt.c: virConnectSetKeepAlive(): - remove check for negative
>                                              values
> * src/rpc/virnetclient.c
> * src/rpc/virnetclient.h: - add virNetClientKeepAliveStop() to disable
>                             keepalive messages
> * src/remote/remote_driver.c: remoteSetKeepAlive(): -add ability to
>                                                      disable keepalives
> ---
> Diff to v2:
> - fixed whitespace
> - added a note that disabling client keepalives does actualy not influence
>   keepalives sent by the daemon
> 
>  src/libvirt.c              |   10 ++++------
>  src/probes.d               |    2 +-
>  src/remote/remote_driver.c |    7 ++++++-
>  src/rpc/virkeepalive.c     |   36 ++++++++++++++++++++++++++----------
>  src/rpc/virkeepalive.h     |    1 +
>  src/rpc/virnetclient.c     |    8 ++++++++
>  src/rpc/virnetclient.h     |    2 ++
>  7 files changed, 48 insertions(+), 18 deletions(-)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]