[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Use common helper when probing qemu capabilities



On 04/26/2012 08:28 AM, Jiri Denemark wrote:
> QEMU binary is called several times when we probe different kinds of
> capabilities the binary supports. This patch introduces new common
> helper so that all probes use a consistent way of invoking qemu.
> ---
>  src/qemu/qemu_capabilities.c |   59 ++++++++++++++++++++++++++---------------
>  src/qemu/qemu_capabilities.h |    5 +++
>  src/qemu/qemu_driver.c       |    9 +++++-
>  3 files changed, 50 insertions(+), 23 deletions(-)

Nice.  Just today, I hit a bug where I wish we were caching qemu
capabilities better, and by filtering things into a common entry point,
I'm hoping it makes future edits able to take advantage of that one
location, rather than chasing down multiple callers.

https://bugzilla.redhat.com/show_bug.cgi?id=816674

At any rate, this patch looks correct:

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]