[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Add support for -no-user-config



On 04/26/2012 08:28 AM, Jiri Denemark wrote:
> Thanks to this new option we are now able to use modern CPU models (such
> as Westmere) defined in external configuration file.
> ---

I agree with your decision to not push this patch until we have a
documented qemu pull request incorporating the qemu side of things, to
ensure that we will match qemu 1.1 semantics.

>  src/qemu/qemu_capabilities.c |    7 ++++++-
>  src/qemu/qemu_capabilities.h |    1 +
>  src/qemu/qemu_command.c      |   11 ++++++-----
>  src/qemu/qemu_driver.c       |    2 +-
>  4 files changed, 14 insertions(+), 7 deletions(-)

When we _do_ get ready to push this, please add a file to
tests/qemuhelpdata corresponding to qemu 1.1, so that we can prove that
we properly detect the new flag bit according to -help output.

ACK to the code that you do have, though.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]